Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

TAC: Fix accessibility issue when the Release announcement is displayed #12482

Merged
merged 3 commits into from
May 2, 2024
Merged

TAC: Fix accessibility issue when the Release announcement is displayed #12482

merged 3 commits into from
May 2, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented May 2, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Closes element-hq/element-web#27412

Needs element-hq/compound-web#163
Update compound to fix the missing aria-labelledby attribute.

@florianduros florianduros added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems backport staging Label to automatically backport PR to staging branch X-Release-Blocker This affects the current release cycle and must be solved for a release to happen labels May 2, 2024
@florianduros florianduros force-pushed the florianduros/tac/fix-accessibility branch from 1488386 to 73968f9 Compare May 2, 2024 12:40
@florianduros florianduros marked this pull request as ready for review May 2, 2024 13:05
@florianduros florianduros requested review from a team as code owners May 2, 2024 13:05
@florianduros florianduros requested review from dbkr and richvdh May 2, 2024 13:05
@florianduros florianduros added this pull request to the merge queue May 2, 2024
Merged via the queue into develop with commit 7193d4c May 2, 2024
42 checks passed
@florianduros florianduros deleted the florianduros/tac/fix-accessibility branch May 2, 2024 13:46
RiotRobot pushed a commit that referenced this pull request May 2, 2024
@florianduros @github-actions
TAC: Fix accessibility issue when the Release announcement is display…
0009db0 
…ed (#12482)

* Update `@vector-im/compound-web`

* Update TAC snapshots

* Update space panel snapshots

(cherry picked from commit 7193d4c)
@RiotRobot RiotRobot mentioned this pull request May 2, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-team

@richvdh richvdh Awaiting requested review from richvdh richvdh is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
backport staging Label to automatically backport PR to staging branch T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility issues on release announcement of TAC
2 participants
@florianduros @t3chguy