Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add Pin/Unpin action in quick access of the message action bar #12897

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Add Pin/Unpin action in quick access of the message action bar #12897

merged 6 commits into from
Aug 21, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Aug 16, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Related to https://github.com/element-hq/element-internal/issues/607.
Figma https://www.figma.com/design/nwbnk8RaZctjrrRGTUcx1X/Pinned-Messages?node-id=38-170276&t=QMMsCWBcCSoSiyn5-0

  • Add pin/unpin action in quick access of the message action bar
  • Use new pin/unpin icon
  • Pin/unpin is available in the context menu of the message action bar only when right clicked (same behaviour than edit, threads etc)
  • Move pinning function from context menu to PinningUtils
Before After
Screenshot 2024-08-19 at 15 33 29 Screenshot 2024-08-19 at 15 31 20
Screenshot 2024-08-19 at 15 33 50 Screenshot 2024-08-19 at 15 31 32
Screenshot 2024-08-19 at 15 34 07 Screenshot 2024-08-19 at 15 31 58

@florianduros florianduros added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 16, 2024
@florianduros florianduros force-pushed the florianduros/pinned-messages/message-action-bar branch from 42fee33 to 0af9e10 Compare August 16, 2024 14:00
@florianduros florianduros force-pushed the florianduros/pinned-messages/message-action-bar branch from 0af9e10 to 2782b80 Compare August 19, 2024 09:31
@florianduros florianduros force-pushed the florianduros/pinned-messages/message-action-bar branch from 38712cf to aed3645 Compare August 19, 2024 13:43
@florianduros florianduros marked this pull request as ready for review August 19, 2024 14:35
@florianduros florianduros requested a review from a team as a code owner August 19, 2024 14:35
dbkr
dbkr approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Good, thorough set of tests.

test/components/views/messages/MessageActionBar-test.tsx Outdated Show resolved Hide resolved
test/components/views/messages/MessageActionBar-test.tsx Outdated Show resolved Hide resolved
test/utils/PinningUtils-test.ts Outdated Show resolved Hide resolved
@florianduros florianduros force-pushed the florianduros/pinned-messages/message-action-bar branch from d70179c to 5af7247 Compare August 21, 2024 08:35
@florianduros florianduros enabled auto-merge August 21, 2024 08:35
@florianduros florianduros added this pull request to the merge queue Aug 21, 2024
Merged via the queue into develop with commit 3d80eff Aug 21, 2024
29 checks passed
@florianduros florianduros deleted the florianduros/pinned-messages/message-action-bar branch August 21, 2024 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @dbkr