Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Install deja-vu font in docker image #12932

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

MidhunSureshR
Copy link
Contributor

Looks like the playwright image which is based on ubuntu does not come preinstalled with the dejavu fonts.
But the screenshot comparison in our CI happens on a version of ubuntu that does have the font.

@MidhunSureshR MidhunSureshR added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 27, 2024
@MidhunSureshR MidhunSureshR requested a review from a team as a code owner August 27, 2024 12:04
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a comment to say it's for RTL rendering, otherwise someone's going to get very confused

@MidhunSureshR MidhunSureshR added this pull request to the merge queue Aug 28, 2024
Merged via the queue into develop with commit 43941ef Aug 28, 2024
29 checks passed
@MidhunSureshR MidhunSureshR deleted the midhun/use-dejavu-font-in-docker-image branch August 28, 2024 07:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants