Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

The pinned message banner or list are triggering 🎉 effect. #12944

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

florianduros
Copy link
Contributor

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

The banner or the list try to decrypt the pinned events.
The room listen to decrypted event and will fire the 🎉 effect if the decrypted event has the 🎉 emoji.

In this case, we are decrypting locally the event to display it so we don't need to fire the event.

@florianduros florianduros added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Sep 2, 2024
@florianduros florianduros changed the title The pinned message banner or list generated 🎉 effect. The pinned message banner or list are triggering 🎉 effect. Sep 2, 2024
@florianduros florianduros marked this pull request as ready for review September 2, 2024 12:21
@florianduros florianduros requested a review from a team as a code owner September 2, 2024 12:21
@florianduros florianduros added this pull request to the merge queue Sep 2, 2024
Merged via the queue into develop with commit 1ac533e Sep 2, 2024
39 checks passed
@florianduros florianduros deleted the florianduros/pinned-messages/tada-emit branch September 2, 2024 16:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants