Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Display the indicator even with one message in pinned message banner #12946

Merged

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Sep 2, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Figma: https://www.figma.com/design/nwbnk8RaZctjrrRGTUcx1X/Pinned-Messages?node-id=131-42784&t=giciZerm4TDEgZhw-4
Display the indicator even when there is one pinned message.

I'm using line-height to center center the text and the text in the previous snapshots wasn't centered.

@florianduros florianduros added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Sep 2, 2024
@florianduros florianduros marked this pull request as ready for review September 2, 2024 15:45
@florianduros florianduros requested a review from a team as a code owner September 2, 2024 15:45
@florianduros florianduros added this pull request to the merge queue Sep 2, 2024
Merged via the queue into develop with commit f033b64 Sep 2, 2024
39 checks passed
@florianduros florianduros deleted the florianduros/pinned-messages/fix/one-pin-message branch September 2, 2024 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants