This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add timezone to user profile #12967
Closed
Add timezone to user profile #12967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 6, 2024
|
@daniellekirkwood tagged as discussed. I think this just needs some thoughts about how best to fit it into the profile view. I'm happy to wait if existing designs are in the process of landing, I can just rebase. |
And automatically refresh the timezone every minute.
3 tasks
Half-Shot
added
the
T-Enhancement
4 tasks
dbkr
approved these changes
Sep 10, 2024
| /** | ||
| * Fetch a user's delclared timezone through their profile, and return | ||
| * a friendly string of the current time for that user. This will keep | ||
| * in sync with the current time, and will be refreshed once a minute. |
There was a problem hiding this comment.
Updating feels like it might be overkill here, especially since it doesn't look like there's any UI to suggest it's dynamically refreshing, but seems fine I guess.
There was a problem hiding this comment.
It just felt weird to me that the time would slowly drift out of date if you left the user open for a minute. I suppose it's an incredibly minor thing, but also I don't think it's a costly rerender.
|
Closing in favor of element-hq/matrix-react-sdk#20 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements MSC4175
Depends on matrix-org/matrix-js-sdk#4391
Design provided at https://www.figma.com/design/gpxHFDTNK796n84r1ZxYG2?node-id=1360-28954#941702635
This provides a basic presentation of a user's current time & timezone on their profile. It also adds a setting to allow publishing the time.
Timezone in user profile
Timezone publish setting
Checklist
public/exportedsymbols have accurate TSDoc documentation.