This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add ignore user API support #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds element-hq/element-web#1767 Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
turt2live
force-pushed
the
travis/ignored_users
branch
from
342b41f to
c0f4c3f
Compare
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
turt2live
force-pushed
the
travis/ignored_users
branch
from
c0f4c3f to
2d51707
Compare
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
turt2live
force-pushed
the
travis/ignored_users
branch
from
f761360 to
3889df6
Compare
This code only kicks in if the user was ignored after an event was sent. The homeserver should prevent other events from coming in. Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
turt2live
changed the title
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
turt2live
force-pushed
the
travis/ignored_users
branch
from
48f6872 to
0363f73
Compare
ara4n
reviewed
Sep 17, 2017
| @@ -228,6 +257,7 @@ module.exports = React.createClass({ | |||
| } | |||
|
|
|||
| this._refreshMediaDevices(); | |||
| this._refreshIgnoredUsers(); | |||
There was a problem hiding this comment.
I guess technically we might want to also _refreshIgnoreUsers() when we receive an ignoring event from the js-sdk. But that's such an edge case i'm happy to ignore it for now :)
There was a problem hiding this comment.
(although given we already have an onAction() here, surely it's just 3 lines to add in a:
case 'ignore_state_changed':
this._refreshIgnoredUsers();
break;
...which almost seems worth it.)
Signed-off-by: Travis Ralston <travpc@gmail.com>
|
this looks excellent - thank you!!! sorry it took us a few days to get to it; with lúke away, me stuck in funding hell and dave up to his eyeballs in perf work we're a bit undermanned. |
|
Thanks @ara4n! 2 days is pretty good compared to some of the other projects I contribute to (/me glares at 2015 PR) |
|
yeah, glad we don't have any like that... glances at #588 :(( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General ticket: element-hq/element-web#1490
/(un)ignore <user>slash commandRequires