Modify GroupView UI #1475
Modify GroupView UI #1475
Conversation
lukebarnard1
commented
Oct 13, 2017
lukebarnard1
commented
- Remove featured users/rooms
- Add "Rooms" section to show all rooms in the group in a room-directory-esque list. This has a "+" button in "edit" mode.
- Make the group view body scrollable
- Remove featured users/rooms - Add "Rooms" section to show all rooms in the group in a room-directory-esque list. This has a "+" button in "edit" mode. - Make the group view body scrollable
…org/matrix-react-sdk into luke/groups-room-directory-esque
| @@ -935,7 +967,12 @@ export default React.createClass({ | |||
| { rightButtons } | |||
| </div> | |||
| </div> | |||
| { roomBody } | |||
| <ScrollPanel className="mx_GroupView_body" | |||
There was a problem hiding this comment.
ScrollPanel might be overkill here as it's designed for timeline style infinite pagination things - in UserSettings we just put a GeminiScrollbar in, for instance.
There was a problem hiding this comment.
Ah, that would make sense
| onChange={this._onLongDescChange} | ||
| tabIndex="3" | ||
| /> | ||
| { this._getFeaturedRoomsNode() } | ||
| { this._getFeaturedUsersNode() } |
There was a problem hiding this comment.
So featured rooms / users are unused now? Should we remove the functions?
There was a problem hiding this comment.
I can't really justify keeping them. Although, we're going to need them Eventually...
| const topic = linkifyString(sanitizeHtml(room.topic || '')); | ||
|
|
||
| const guestRead = room.world_readable ? ( | ||
| <div className="mx_RoomDirectory_perm">{ _t('World readable') }</div> |
There was a problem hiding this comment.
I guess this should share code with the public room directory, at least in the long term
There was a problem hiding this comment.
Sure, in the long term. It was too entrenched in RoomDirectory so I decided not to do that yet.
|
|
||
| return <tr key={room.room_id} onClick={this.onClick}> | ||
| <td className="mx_RoomDirectory_roomAvatar"> | ||
| <BaseAvatar width={24} height={24} resizeMethod='crop' |
There was a problem hiding this comment.
room isn't actually a Room object here
| <div className="mx_RoomDirectory_name">{ name }</div> | ||
| { perms } | ||
| <div className="mx_RoomDirectory_topic" | ||
| onClick={function(e) { e.stopPropagation(); }} |
There was a problem hiding this comment.
What's this for? (It's also making a new function on each render so will break react's DOM diffing)
| @@ -148,6 +148,7 @@ module.exports = React.createClass({ | |||
| onFillRequest: function(backwards) { return Promise.resolve(false); }, | |||
| onUnfillRequest: function(backwards, scrollToken) {}, | |||
| onScroll: function() {}, | |||
| onResize: function() {}, | |||
There was a problem hiding this comment.
Is this still useful to add? Seems like it might be
There was a problem hiding this comment.
Oh. I had left it in unintentionally. I think it is useful; things might not need to do anything if the SP changes size.
CSS for Modifying GroupView UI matrix-org/matrix-react-sdk#1475
