This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Move react-addons-test-utils to react-dom/test-utils #1914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
approved these changes
Jun 8, 2018
|
Can you do the DCO signoff please: https://github.com/matrix-org/matrix-react-sdk/blob/master/CONTRIBUTING.rst |
Signed-off-by: Akihiko Odaki <nekomanma@pixiv.co.jp>
|
34f5fb9 added Signed-off-by. I also added Signed-off-by to my other pull requests. |
|
Thanks for making this contribution a while back. It looks like this needs a rebase to resolve some conflicts since we have switched to Yarn. Do you still want move forward with this? I will do my best to re-review it quickly after you update it. |
|
Since there's been no reply, I'll assume this has been abandoned. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See facebook/react@3a7eef2. This is a preparation for element-hq/element-web#6410.