This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
hide already chosen results from AddressPickerDialog #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
lukebarnard1
suggested changes
Jun 21, 2018
| @@ -510,6 +510,10 @@ module.exports = React.createClass({ | |||
| const AddressSelector = sdk.getComponent("elements.AddressSelector"); | |||
| this.scrollElement = null; | |||
|
|
|||
| // Use set to avoid O(n*m) operation | |||
| const selectedAddresses = new Set(this.state.userList.map(({address}) => address)); | |||
There was a problem hiding this comment.
I think we should rename userList and selectedAddresses to selectedList and likewise rename queryList to suggestedList.
@t3chguy, wdyt? Worth the faff?
| }); | ||
|
|
||
| const queryList = this.state.queryList.filter(({address, addressType}) => { | ||
| return !selectedAddresses[addressType] || !selectedAddresses[addressType].has(address); |
There was a problem hiding this comment.
This would be easier to grok if it were !(condition and condition) imo. It should make it clearer that the first condition is a effectively a null-guard.
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
lukebarnard1
approved these changes
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first half of #1678
Fixes element-hq/element-web#5792