This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix Promise.defer warning in ScalarAuthClient.js #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronraimist
force-pushed
the
promise-defer-scalarauthclient
branch
from
162ab74
to
72cd8a3
Compare
Signed-off-by: Aaron Raimist <aaron@raim.ist>
aaronraimist
force-pushed
the
promise-defer-scalarauthclient
branch
from
72cd8a3
to
ef3d1a6
Compare
|
Thanks for taking a look at this! It looks to be on the right track - do you know by chance how many more there are? If there's a lot, then it might be best to break it out into smaller chunks to keep the reviews a bit more manageable. |
Closed
dbkr
approved these changes
Oct 2, 2018
|
@turt2live Looks like there are 18 of these in 10 files. How many PRs should I split that up into? |
|
One is probably fine, although it might be massive. |
|
i’d go for it in one PR as they are all the same manoeuvre. thank you for fixing them!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do these look good? If so I can start working on the other places where this warning happens but I wanted to check to make sure I was doing it right.
Tests seem to pass.
element-hq/element-web#7409