This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Load fonts and images via source-relative URLs and requires #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that themes which include `light/css/_base.scss` (currently Dark and Status) won't be forced to have Light's font-faces included. This only really matters for Status, which uses different fonts throughout.
Adds a `$res` SCSS variable set to the path from the root SCSS file to the `res` directory. This is a different base path than previously used in CSS URLs (it goes up 3 directories instead of 2), because Webpack will now be resolving images relative to the root SCSS file, so the path corresponds to a source tree location, instead of a path in the build output tree. Defining this variable has two main goals: * URLs are a bit easier to read * The path can be overridden, which is needed for external (riot-web) themes
I am about to run some code replacements that might make lines too long, so with this change I know we're starting from 0 line length warnings.
This allows Webpack to insert the proper image URL after builds steps like adding a hash and so on. The path you supply to `require` is relative to the JS source file, just like any other would be.
jryans
changed the title
|
I think CI is confused here, so I am going to ignore it and request review. I'll make sure everything works as expected before merging. |
|
The Edit: to fix the |
|
Removing review request for now. There are still a few issues with Karma tests to fix. |
|
Karma issues resolved and CI is green now. |
turt2live
approved these changes
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of adding versioned URLs in element-hq/element-web#7932, we need to convert all image references to flow through the build system.
This is a change that everyone on the team should be aware of, as it affects how image paths are written. In particular:
./res/themes/dharma/css/dharma.scss$(res)helper variable has been defined so we can writeurl('$(res)/img/cancel.svg')while still supporting themes in different places (such as Status inriot-web)Needed for element-hq/element-web#7932
Used in element-hq/element-web#8159