This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement the Advanced tab of new room settings #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I should really just get something that does this for me prior to opening a PR
|
Once again, test failures are expected because of branch mismatches |
jryans
approved these changes
Jan 30, 2019
| }; | ||
| } | ||
|
|
||
| componentWillMount(): void { |
There was a problem hiding this comment.
What's this lone type annotation-like thing doing here?
There was a problem hiding this comment.
Something my IDE autocompletes and I constantly forget to remove. I can remove it if wanted, and i should probably pay attention to what I'm overloading.
There was a problem hiding this comment.
It seems a bit random to type only one method, so I guess I'd remove it... hopefully it's configurable in your IDE?
There was a problem hiding this comment.
probably. I write a lot of typescript and that's probably interfering with the jsx settings a bit. I'll just pay a bit more attention to it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8258
Part of element-hq/element-web#7606