Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Welcome page cleanup #2611

Merged
merged 5 commits into from
Feb 12, 2019
Merged

Welcome page cleanup #2611

merged 5 commits into from
Feb 12, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Feb 11, 2019 •
edited
Loading

Fixed up a few edge cases with the welcome page, such as:

Used by element-hq/element-web#8525

@jryans jryans mentioned this pull request Feb 11, 2019
Merged
@jryans jryans requested a review from a team February 11, 2019 15:33
bwindels
bwindels reviewed Feb 11, 2019
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved too soon, sorry. Only read through 1 commit :)

bwindels
bwindels approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, 1 comment

src/components/structures/RoomView.js Outdated Show resolved Hide resolved
@jryans jryans merged commit fbc1779 into develop Feb 12, 2019
This was referenced Feb 12, 2019
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwindels bwindels bwindels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jryans @bwindels