This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix registration after clicking email link #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't correctly jumping into the appropriate bit of the registration flow when coming in from an email link. * If we have client secret / sessionId, go straight to registration phase * Don't reset server URLs when the server type component tells us its initial value * Confusingly, pass the custom server URL as 'default server URL' to the custom server type, as this is what we want the inital section to be based on. Fixes element-hq/element-web#8490
jryans
approved these changes
Feb 13, 2019
| let initialPhase = PHASE_SERVER_DETAILS; | ||
| if ( | ||
| // if we have these two, skip to the good bit | ||
| (this.props.clientSecret && this.props.sessionId) || |
There was a problem hiding this comment.
Please add a note that these can come in from email verification, as a reminder for the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't correctly jumping into the appropriate bit of the registration
flow when coming in from an email link.
initial value
the custom server type, as this is what we want the inital section
to be based on.
Fixes element-hq/element-web#8490