Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add onClick to Markdown buttons #2677

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Add onClick to Markdown buttons #2677

merged 2 commits into from
Feb 22, 2019

Commits on Feb 22, 2019

  1. Change Markdown buttons to onClick 

    `AccessibleButton` expects click handlers, which we can use here, as long we
make some additional changes to avoid race processing the new state (see
subsequent patch).

Fixes element-hq/element-web#8866
    @jryans
    jryans committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    3e6199c View commit details
    Browse the repository at this point in the history

  2. Isolate rich text notifications from other input changes 

    The step that would notify parent components of rich text state changes was
stirred into the input's change handler, which leads to race which the parent is
sometimes notified of the old rich text state instead of the new.

Here we avoid this complication by using a separate path for sending the rich
text state when we know we have updated it correctly.
    @jryans
    jryans committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    ccd4dee View commit details
    Browse the repository at this point in the history