This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Scroll investigation changes #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it's easy to confuse it with room widgets, but has nothing to do with it.
seems to cause more harm than good in some cases and we shouldn't need it if we get our calls to onHeightChanged in order.
15 tasks
jryans
approved these changes
Mar 8, 2019
| @@ -181,12 +161,6 @@ module.exports = React.createClass({ | |||
|
|
|||
| componentDidMount: function() { | |||
| this.checkScroll(); | |||
|
|
|||
| this._timelineSizeObserver = createTimelineResizeDetector( | |||
There was a problem hiding this comment.
You should also remove the matching block in componentWillUnmount as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermediate result of the scroll jump investigations. I don't expect this to fix the problem at all, but still some changes worthwhile to include:
onWidgetLoadonHeightChange where needed seems like a better and more compatible way of preventing jumps).Related to element-hq/element-web#8565