This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Don't trample over existing sessions when verifying email addresses #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#6875 Instead of overwriting what we have, we'll load the session we have and try to warn the user that they have verified an address for someone else.
turt2live
force-pushed
the
travis/verify-email-state
branch
from
961f155 to
0e16f3a
Compare
jryans
approved these changes
Mar 8, 2019
src/Lifecycle.js
Outdated
| @@ -214,6 +225,16 @@ function _registerAsGuest(hsUrl, isUrl, defaultDeviceDisplayName) { | |||
| }); | |||
| } | |||
|
|
|||
| function _getLocalstorageSessionVars() { | |||
There was a problem hiding this comment.
Nit: Perhaps _getLocalStorage... with capital S?
dbkr
added a commit
that referenced
this pull request
May 14, 2019
Regressed in #2768 where we check for an existing stored account first and restore that instead if it exist, telling the user. We usually make a guest account when the user first hits the page though, so this just restored this guest account. Don't restore the account if it's just a guest account (which, as per comment, is not perfect, but is definitely better than the current behaviour). Fixes element-hq/element-web#9581
dbkr
added a commit
that referenced
this pull request
May 14, 2019
Regressed in #2768 where we check for an existing stored account first and restore that instead if it exist, telling the user. We usually make a guest account when the user first hits the page though, so this just restored this guest account. Don't restore the account if it's just a guest account (which, as per comment, is not perfect, but is definitely better than the current behaviour). Fixes element-hq/element-web#9581
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#6875
Instead of overwriting what we have, we'll load the session we have and try to warn the user that they have verified an address for someone else.