Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Alert the user to unread notifications in prior versions of rooms #2831

Merged
merged 3 commits into from
Mar 27, 2019
Merged

Alert the user to unread notifications in prior versions of rooms #2831

merged 3 commits into from
Mar 27, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Mar 27, 2019 •
edited
Loading

Fixes element-hq/element-web#8161

UX does not have signoff, but is as proposed (the bar is clickable to go to the room):

image

@turt2live turt2live requested review from nadonomy and a team March 27, 2019 01:24
bwindels
bwindels approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm otherwise!

src/components/structures/RoomView.js Outdated Show resolved Hide resolved
nadonomy
nadonomy approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the padding to better horizontally align the message content to the room avatar, committed directly to this branch.

LGTM!

@turt2live turt2live merged commit 64a6b47 into develop Mar 27, 2019
@turt2live turt2live deleted the travis/hidden-bing branch March 27, 2019 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwindels bwindels bwindels approved these changes

@nadonomy nadonomy nadonomy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turt2live @bwindels @nadonomy