This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add custom tooltips and scrolling to breadcrumbs #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#9303 We have to track our own onHover for this, and out of safety we ensure that exactly 1 room is hovered at a time.
Fixes element-hq/element-web#8714 Fixes element-hq/element-web#8890 Fixes element-hq/element-web#9034 Fixes element-hq/element-web#8954 This turned out to be much more complicated than it needed to be. We use an IndicatorScrollbar to do all the math for us and some minor changes have been made so it can flag left/right overflow. The complicated part is the css changes which make the gradients work: unlike the RoomSubList, we have to calculate the offset of the indicators (gradients) on our own because position:sticky doesn't work horizontally. The changes to the css (well, mostly pointer-events:none) make it so the gradient doesn't interfere with the room avatars. 9034 and 8954 are fixed by this because they represent an overflow-x:none style breakage where browsers won't let you scroll without a scrollbar. The gradient offset problem is also demonstrated in 8954.
bwindels
approved these changes
Mar 28, 2019
|
(requesting review to make sure the question gets answered, and that said answer makes sense) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#9303
Fixes element-hq/element-web#8714
Fixes element-hq/element-web#8890
Fixes element-hq/element-web#9034
Fixes element-hq/element-web#8954
Reviewer: It may be easier to review this commit-by-commit, which has more information.
I've bundled these together to try and reduce merge conflicts and because they are both vaguely visual. I was planning on including more, however the scrolling stuff is sufficiently complicated to scare me away from that.