Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Small scroll fixes #2865

Merged
merged 3 commits into from
Apr 3, 2019
Merged

Small scroll fixes #2865

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
726e911
allow fractional values for scrollTop above and below expected value
bwindels Apr 2, 2019
86c13b9
increase PAGE_SIZE so users can scroll up already while waiting for pag.
bwindels Apr 2, 2019
fee8d79
comment for PAGE_SIZE
bwindels Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/components/structures/ScrollPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,11 @@ const UNPAGINATION_PADDING = 6000;
// The number of milliseconds to debounce calls to onUnfillRequest, to prevent
// many scroll events causing many unfilling requests.
const UNFILL_REQUEST_DEBOUNCE_MS = 200;

const PAGE_SIZE = 200;
// _updateHeight makes the height a ceiled multiple of this so we
// don't have to update the height too often. It also allows the user
// to scroll past the pagination spinner a bit so they don't feel blocked so
// much while the content loads.
const PAGE_SIZE = 400;
bwindels marked this conversation as resolved.
Show resolved Hide resolved

let debuglog;
if (DEBUG_SCROLL) {
Expand Down Expand Up @@ -222,10 +225,12 @@ module.exports = React.createClass({
// whether it will stay that way when the children update.
isAtBottom: function() {
const sn = this._getScrollNode();
// fractional values for scrollTop happen on certain browsers/platforms
// fractional values (both too big and too small)
// for scrollTop happen on certain browsers/platforms
// when scrolled all the way down. E.g. Chrome 72 on debian.
// so ceil everything upwards to make sure it aligns.
return Math.ceil(sn.scrollTop) === Math.ceil(sn.scrollHeight - sn.clientHeight);
// so check difference <= 1;
return Math.abs(sn.scrollHeight - (sn.scrollTop + sn.clientHeight)) <= 1;

},

// returns the vertical height in the given direction that can be removed from
Expand Down