Changing the color of highlights to avoid confusions

[heIsThePirate]

(with the aim of resolving issues #9070 and related)
From:

to:

Signed-off-by: Mohit Singh mohitsingh1997@gmail.com

[turt2live]

Thanks for doing this! It looks like the right option in general, however I do wonder how it handles keyword or plaintext notifications. Some clients (namely our own mobile clients, embarrassingly) still don't send pills when mentioning people, which may cause this to unintentionally break. If you've tested this, please include screenshots :)

[bmarty]

FTR RiotX will send pills

[heIsThePirate]

Thanks for the approval and the feedback @turt2live
I have tested this in a dev environment set up on my PC for the 'riot-web' and the above screenshots in my original post are for the same. Now, as @bmarty has pointed out that 'RiotX' will send pills and according to the announcement, the codebase of 'riot-android' would be replaced with that of 'RiotX', I don't think that would be a problem anymore...In the meanwhile, I think the stylesheet is already overwritten for the mobile client as this is what I observe in the 'riot-android' for the same content: https://ibb.co/zmB6W5P
I am not much familiar with Android still, I would try to test it with the gradle and update if any issues are found.

[jryans]

Riot iOS does not appear to send pills at the moment.

[turt2live]

Keyword notifications are also not pills, so this is still a real concern.

[jryans]

@turt2live So does it mean we're not ready to merge a change like this, then?

[turt2live]

If the message isn't highlighted when there's no pills, I'm afraid so.

[jryans]

From the PR discussion, it sounds like we need to find a different approach that still highlights even without pills.

doesn't apply

[turt2live]

@heIsThePirate just checking in - are you able to take this on still? If not, we can add it to our backlog.

[heIsThePirate]

@heIsThePirate just checking in - are you able to take this on still? If not, we can add it to our backlog.

I have tried several things but wasn't able to test properly due to the recent chaos, this will take some more time. I am busy with exams right now so I guess I would take this on again in a week. Until then, if required, it may be added to the backlog. Thanks!

[jryans]

Since we have some unresolved concerns (which I am not quite sure how we would resolve at the moment), and also the author is busy for now, I think it's best to close this for now. Please feel free to open a new PR if it would address the concerns highlighted here. Thanks!