Fix: maintain caret at current line when position is on newline part #3029

bwindels · 2019-05-24T16:56:40Z

Fix for element-hq/element-web#9803
Fixes multiple small issues:

put caret at end of pill on autocomplete when there is no plain part behind it on the same line
fix not all nodes being cleared when inserting a newline between two lines
fix setting caret at editor end when inserting a newline between two lines

nextSibling returned null after calling removeNode, so get the nextSibling first

instead of setting at the end of the editor

jryans

Seems logical!

bwindels added 3 commits May 24, 2019 18:54

maintain caret at current line when position is on newline part

b259258

remove all non-first-br nodes on new empty line, not just first one

4fc2302

nextSibling returned null after calling removeNode, so get the nextSibling first

fallback to setting caret on line node for empty lines

6b680ff

instead of setting at the end of the editor

bwindels marked this pull request as ready for review May 28, 2019 08:36

bwindels requested a review from a team May 28, 2019 08:37

jryans approved these changes May 29, 2019

View reviewed changes

bwindels merged commit eb8dd52 into develop May 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: maintain caret at current line when position is on newline part #3029

Fix: maintain caret at current line when position is on newline part #3029

bwindels commented May 24, 2019 •

edited

Loading

jryans left a comment

Fix: maintain caret at current line when position is on newline part #3029

Fix: maintain caret at current line when position is on newline part #3029

Conversation

bwindels commented May 24, 2019 • edited Loading

jryans left a comment

Choose a reason for hiding this comment

bwindels commented May 24, 2019 •

edited

Loading