This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Simplify email registration #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You now don't get automatically logged in after finishing registration. This makes a whole class of failures involving race conditions and multiple devices impossible. element-hq/element-web#9586
bwindels
approved these changes
Jun 13, 2019
| // Only send the bind params if we're sending username / pw params | ||
| // (Since we need to send no params at all to use the ones saved in the | ||
| // session). | ||
| const bindThreepids = this.state.formVals.password ? { | ||
| email: true, | ||
| msisdn: true, | ||
| } : {}; | ||
| // Likewise inhibitLogin | ||
| if (!this.state.formVals.password) inhibitLogin = null; |
There was a problem hiding this comment.
Looking at the render method, I guess this means the client that was opened from the e-mail. If so, could you clarify in the comment above? Also, I thought that if you also had to click "Log in" in the browser that was opened from the e-mail? Probably misunderstanding something ...
There was a problem hiding this comment.
ah yes, sorry - this was from when I was going to put a button in the original client to re-submit the request, which we've now decided not to do.
and fix docs.
dbkr
added a commit
that referenced
this pull request
Jun 14, 2019
#3101 meant we don't get logged straight in after registering if using an email address, but this was the point at which we made a chat with the welcome user. Instead, set a flag in memory that we should try & make a chat with the welcome user for that user ID if we get a session for them. Of course, if the user logs in on both tabs, this would mean each would make a chat with the welcome user (although actually this was a problem with the old code too). Check our m.direct to see if we've started a chat with the welcome user before making one (which also means we have to make sure the cached sync is up to date... see comments).
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You now don't get automatically logged in after finishing registration (if you registered with an email address). This makes a whole class of failures involving race conditions and multiple devices impossible.
Instead, this happens on the page you started on:
...and this happens on the page you got from clicking the email link:
Fixes element-hq/element-web#9586
Requires matrix-org/matrix-js-sdk#953