This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
When joining from room directory, use auto_join #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
The end to end tests are (legitimately) failing, as they expect a "Join" button after clicking on a room in the room directory. |
|
I'll try to have a look to fix the e2e tests ... might even be a good time to put them into the react-sdk... |
|
So the E2E tests are right here, I missed that I moved both the room directory results and the search box enter/join button to auto_join when only the latter should have been. Resolved that now |
turt2live
approved these changes
Jun 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#5265
Does have the side-effect of picking an already-joined room from Room Directory says "Joining..." instead of "Loading..." because of the alias -> id resolution being async, related to the URL change issue not being instant with aliases
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com