Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Progress towards React 16 compatibility #3276

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Progress towards React 16 compatibility #3276

merged 3 commits into from
Aug 6, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 5, 2019

  • Update react-gemini-scrollbar to pull in its React 16 compatibility
  • Correct the default props syntax in create-react-class
  • Start transitioning from React.createClass to create-react-class

Subset of #3270

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes me slightly sad that we're going with create-react-class instead of real ES6 classes, but not enough to block this PR.

@t3chguy
Copy link
Member Author

t3chguy commented Aug 6, 2019

it makes me slightly sad that we're going with create-react-class instead of real ES6 classes, but not enough to block this PR.

Me too @turt2live but I know ES classes will make the PRs take a lot longer, I'd rather get everything up to React 16 and THEN transition to ES6 classes, as well as TS :D

@t3chguy t3chguy merged commit daf1a79 into develop Aug 6, 2019
@t3chguy t3chguy deleted the t3chguy/react16_1 branch May 25, 2020 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants