Add option to disable typing notifications

[schwukas]

Resolves this riot-im issue.

Signed-off-by: Lukas Schwarz ghub@posteo.se

[t3chguy]

Re sign-off:

I believe as per the contributing doc it has to be name and e-mail address.

Also your name has to fit within:

We accept contributions under a legally identifiable name, such as your name on government documentation or common-law names (names claimed by legitimate usage or repute). Unfortunately, we cannot accept anonymous contributions at this time.

[schwukas]

That's alright. I fixed it :)

[dbkr]

First step here I think is a product decision on whether we want this option.

Code-wise, I'd be a lot happier about merging this if it came with a test, otherwise it's liable to just end up getting broken at some point down the line and we won't notice.

[schwukas]

I don't see any reason why this option would be unwanted. I've heard several people wishing for it because the typing notifications are distracting to them. I just find them unnecessary. Since this options defaults to "show typing notifications" anyway, I don't understand the problem of including it. However, this decision is not up to me.
If you find it to be a worthy inclusion just tell me, and I'll gladly add a test.

[t3chguy]

I'd say given Tom labelled it as a feature with a priority it seems like having it behind a default-off setting should be fine

[turt2live]

This shouldn't be here - there's no legacy setting to maintain.

[schwukas]

Are you referring solely to line 231? It's a bit unclear from how github marked it.

[turt2live]

yes, 231. The invertedSettingName is a backwards compatibility thing, but there's nothing to be backwards compatible with here.

[turt2live]

I'd say given Tom labelled it as a feature with a priority it seems like having it behind a default-off setting should be fine

It's also been a year - we should double check.

[t3chguy]

This is now a thing