This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
[BREAKING] Refactor the entire build process for babel@7 and TypeScript (chunk 1 of many) #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks the tests
We're switching to Jest anyways, and getting these things to run is basically impossible at the moment.
They rely on a working riot-web build, which this is not.
turt2live
commented
Dec 12, 2019
| @@ -1,20 +1,25 @@ | |||
| { | |||
| "sourceMaps": "inline", | |||
There was a problem hiding this comment.
this is theoretically the best way to get the sourcemaps into webpack for riot-web
MatrixClientPeg in particular doesn't work very well with this.
This was referenced Dec 13, 2019
dbkr
reviewed
Dec 13, 2019
| "check-type" | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there any way to at least not have these repeated between all our projects?
There was a problem hiding this comment.
at least not yet, I think.
dbkr
approved these changes
Dec 17, 2019
|
yup, absolutely. We kinda need them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be paired with matrix-org/matrix-js-sdk#1113
Note: This is set to merge against
travis/sourcemapsbecause it breaks all the downstream builds.It's not fair to call this part 1 of many because this isn't a distinct part: it's more a chunk of work which is of reviewable size (hopefully).
Features:
As mentioned above, this isn't a complete unit of work - jsut a big rock-shaped lump of changes. Sorry.
This is a step towards being a boring SDK and not anticipating an install location.
This commit requires a major version bump of the SDK.