This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 829
Initial support for verification in right panel #3796
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temporary code, as ux is not complete
3 tasks
turt2live
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like the js-sdk, this is hard to follow but I think it's fine. It's slightly easier to follow than the js-sdk though, so there's that.
I've also merged in develop here having broken the build system |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#1140
Part of element-hq/element-web#11224
Two big things happen in this PR (and the js-sdk PR):
KeyVerificationStateObserver
intoVerificationRequest
(in the js-sdk), and attach that object to all the involved events asevent.verificationRequest
. Synchronizing the toast, event tiles and right panel is a lot easier this way.VerificationToast
,MKeyVerificationRequest
andMKeyVerificationConclusion
needed to be ported to this.I have tested that to_device verification still works, especially for verifying your own devices, as we might still need this for cross-signing.
Apologies that the commit log is a bit messy, might be better to review the changes in their entirety.
Cleanups still to do: