Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add Reject & Ignore user button to invites view #3909

Merged
merged 4 commits into from
Jan 23, 2020
Merged

Add Reject & Ignore user button to invites view #3909

merged 4 commits into from
Jan 23, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 23, 2020 •
edited
Loading

@t3chguy t3chguy requested review from a team and nadonomy January 23, 2020 11:57
@nadonomy
Copy link
Contributor

Thanks!

@t3chguy small design nit, the space between the text only buttons is unbalanced and looks uncomfortable to the eye. I'm not sure how the components are built, but from unscientifically measuring your screenshot:

image

I'm measuring the space at 28px vs 20px, so it think an extra 8px needs to be added for it to be consistent and look correct to the eye.

@t3chguy
Copy link
Member Author

t3chguy commented Jan 23, 2020

image

@t3chguy t3chguy merged commit 26aa4bb into develop Jan 23, 2020
@t3chguy t3chguy deleted the t3chguy/invite_reject_ignore branch May 25, 2020 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@foldleft foldleft foldleft approved these changes

@nadonomy nadonomy Awaiting requested review from nadonomy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ignore user button to invite screen
3 participants
@t3chguy @nadonomy @foldleft