This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Support SSO for interactive authentication #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works well enough to start doing design.
7 tasks
dbkr
reviewed
Mar 31, 2020
dbkr
reviewed
Mar 31, 2020
Co-Authored-By: David Baker <dbkr@users.noreply.github.com>
dbkr
approved these changes
Apr 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#12692
Fixes element-hq/element-web#12028
Requires matrix-org/synapse#7102
For matrix-org/matrix-spec-proposals#2454
Designs: https://www.figma.com/file/0x3jONAjbrzNutZnW89h6x/SSO-Auth?node-id=0%3A1
May be best to review this commit by commit.
Device deletion
Note: Some freehanding was done on the copy to support multiple device deletion.
Adding email
Adding phone number
You'll have to trust me when I say this looks the same as the email dialog, just with some words changed.
Account deactivation
To be handled by a different PR (complexity is higher than the other dialogs in this PR) - see element-hq/element-web#12940