Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Social Login and login delight tweaks #5426

Merged
merged 24 commits into from
Dec 2, 2020
Merged

Social Login and login delight tweaks #5426

merged 24 commits into from
Dec 2, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Nov 18, 2020 •
edited
Loading

@t3chguy t3chguy mentioned this pull request Nov 20, 2020
Merged
@t3chguy t3chguy marked this pull request as ready for review November 25, 2020 10:37
@t3chguy t3chguy requested review from a team November 25, 2020 11:38
@jryans jryans requested review from jryans and removed request for a team November 26, 2020 12:23
jryans
jryans suggested changes Nov 26, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's looking great, and definitely improves lots of cruft in the auth flows at the same time. 😄 I've added a few small questions on some parts.

res/css/views/dialogs/_RegistrationEmailPromptDialog.scss Show resolved Hide resolved
src/components/views/auth/RegistrationForm.tsx Show resolved Hide resolved
src/components/views/dialogs/RegistrationEmailPromptDialog.tsx Outdated Show resolved Hide resolved
src/components/views/dialogs/RegistrationEmailPromptDialog.tsx Show resolved Hide resolved
src/components/structures/auth/Login.tsx Outdated Show resolved Hide resolved
src/components/views/auth/ServerConfig.js Outdated Show resolved Hide resolved
src/components/views/elements/Field.tsx Show resolved Hide resolved
res/css/views/dialogs/_ServerPickerDialog.scss Show resolved Hide resolved
src/components/views/dialogs/ServerPickerDialog.tsx Outdated Show resolved Hide resolved
src/components/views/elements/ServerPicker.tsx Outdated Show resolved Hide resolved
@BillCarsonFr BillCarsonFr mentioned this pull request Nov 26, 2020
Closed
nadonomy
nadonomy approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some small iteration tweaks, but happy to iterate on those over time. LGTM!

@nadonomy nadonomy mentioned this pull request Dec 1, 2020
Closed
@t3chguy t3chguy requested a review from jryans December 1, 2020 12:05
jryans
jryans approved these changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great to me! 😄

@t3chguy
Copy link
Member Author

t3chguy commented Dec 2, 2020

At this point, blocking this until post-RC

@t3chguy t3chguy mentioned this pull request Dec 2, 2020
Closed
@t3chguy t3chguy merged commit a115954 into develop Dec 2, 2020
@t3chguy t3chguy deleted the t3chguy/socials branch December 2, 2020 15:48
@robintown robintown mentioned this pull request Dec 4, 2020
Open
@bhack bhack mentioned this pull request Dec 8, 2020
Closed
@richvdh richvdh mentioned this pull request Mar 1, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nadonomy nadonomy nadonomy approved these changes

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stronger wording in warning for signup without email
3 participants
@t3chguy @jryans @nadonomy