This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix new rooms being titled 'Empty Room' #5587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Gwynne dangwynne1@gmail.com
dangwynne
changed the title
dangwynne
changed the title
|
@dangwynne You can add "Fixes #16270" ( |
jryans
changed the title
jryans
changed the title
jryans
suggested changes
Jan 29, 2021
jryans
approved these changes
Feb 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The room name is not included in the original sync message received when the room is created so when the RoomTile instance is initially created the
calculateRoomNamemethod on room.js returns "Empty Room".On creation of the Room Tile I have added an event handler on the Room model to listen for "Room.name" events and redraw the tile when the event is received.
Fixes element-hq/element-web#16270