Add a warning on E2EE rooms if you try to make them public

src/components/views/settings/tabs/room/SecurityRoomSettingsTab.js

@@ -91,7 +91,24 @@ export default class SecurityRoomSettingsTab extends React.Component {
         if (refreshWhenTypes.includes(e.getType())) this.forceUpdate();
     };
 
-    _onEncryptionChange = (e) => {
+    _onEncryptionChange = async (e) => {
+        if (this.state.joinRule == "public") {
+            const {finished} = Modal.createTrackedDialog('Confirm Public Encrypted Room', '', QuestionDialog, {
+                title: _t('Enable encryption in a public room?'),
+                description: _t(
+                    "Note that enabling encryption in public rooms renders the " +
+                    "encryption pointless, wastes processing power, and can cause " +
+                    "performance problems. Please consider creating a separate " +
+                    "encrypted room.",
+                ),
+            });
+            const [confirm] = await finished;
+            if (!confirm) {
+                this.setState({encrypted: false});
+                return;
+            }
+        }
+
         Modal.createTrackedDialog('Enable encryption', '', QuestionDialog, {
             title: _t('Enable encryption?'),
             description: _t(
@@ -147,7 +164,7 @@ export default class SecurityRoomSettingsTab extends React.Component {
         });
     };
 
-    _onRoomAccessRadioToggle = (roomAccess) => {
+    _setRoomAccess = (roomAccess) => {
         //                         join_rule
         //                      INVITE  |  PUBLIC
         //        ----------------------+----------------
@@ -191,6 +208,29 @@ export default class SecurityRoomSettingsTab extends React.Component {
             console.error(e);
             this.setState({guestAccess: beforeGuestAccess});
         });
+    }
+
+    _onRoomAccessRadioToggle = (roomAccess) => {
+        if (
+            this.state.encrypted &&
+            this.state.joinRule != "public" &&
+            roomAccess != "invite_only"
+        ) {
+            Modal.createTrackedDialog('Confirm Public Encrypted Room', '', QuestionDialog, {
+                title: _t('Confirm making this room public?'),
+                description: _t(
+                    "Making end-to-end encrypted rooms public renders the " +
+                    "encryption pointless, wastes processing power, and can cause " +
+                    "performance problems. Please consider creating a separate " +
+                    "unencrypted public room.",
+                ),
+                onFinished: (confirm) => {
+                    if (confirm) this._setRoomAccess(roomAccess);
+                },
+            });
+        } else {
+            this._setRoomAccess(roomAccess);
+        }
     };
 
     _onHistoryRadioToggle = (history) => {

src/i18n/strings/en_EN.json

@@ -1335,8 +1335,12 @@
     "Roles & Permissions": "Roles & Permissions",
     "Permissions": "Permissions",
     "Select the roles required to change various parts of the room": "Select the roles required to change various parts of the room",
+    "Enable encryption in a public room?": "Enable encryption in a public room?",
+    "Note that enabling encryption in public rooms renders the encryption pointless, wastes processing power, and can cause performance problems. Please consider creating a separate encrypted room.": "Note that enabling encryption in public rooms renders the encryption pointless, wastes processing power, and can cause performance problems. Please consider creating a separate encrypted room.",
     "Enable encryption?": "Enable encryption?",
     "Once enabled, encryption for a room cannot be disabled. Messages sent in an encrypted room cannot be seen by the server, only by the participants of the room. Enabling encryption may prevent many bots and bridges from working correctly. <a>Learn more about encryption.</a>": "Once enabled, encryption for a room cannot be disabled. Messages sent in an encrypted room cannot be seen by the server, only by the participants of the room. Enabling encryption may prevent many bots and bridges from working correctly. <a>Learn more about encryption.</a>",
+    "Confirm making this room public?": "Confirm making this room public?",
+    "Making end-to-end encrypted rooms public renders the encryption pointless, wastes processing power, and can cause performance problems. Please consider creating a separate unencrypted public room.": "Making end-to-end encrypted rooms public renders the encryption pointless, wastes processing power, and can cause performance problems. Please consider creating a separate unencrypted public room.",
     "Guests cannot join this room even if explicitly invited.": "Guests cannot join this room even if explicitly invited.",
     "Click here to fix": "Click here to fix",
     "To link to this room, please add an address.": "To link to this room, please add an address.",