This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks 👋 ,
This PR fixes element-hq/element-web#15710
The issue stemmed from the fact that
document.getSelection()
would be empty when called insideBasicMessageComposer.tsx#onFormatAction
.After a bit of digging around it appears that Safari resets the selection if a user clicks on something different than a
<button type="button">
(which is odd given that passing therole="button"
attribute down should help)My fix is to essentially use the more semantic HTML tag. I had a bit of CSS tweaking as
button
inherit a background colour and have a different inline type compared todiv
.There are references to an
as
prop on theAccessibleButton
component but could not see it anywhere in the proptypes, I have assumed thatelement
was the appropriate prop to use herePS: I have updated docs where names have gone stale after migrating from JS to TS