Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix page up/down scrolling only half a page #5920

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

aaronraimist
Copy link
Contributor

Signed-off-by: Aaron Raimist <aaron@raim.ist>
@grahamperrin

This comment has been minimized.

Signed-off-by: Aaron Raimist <aaron@raim.ist>
@t3chguy t3chguy requested a review from a team April 26, 2021 08:04
@grahamperrin
Copy link

grahamperrin commented Apr 26, 2021

0.9 of a page feels/looks good to me.


As far as I can tell, the only oddity, and this is out of scope, is when not enough of the next page is 'buffered' before paging down. When, for example, there's relatively little space between the foot of the scroller and the foot of the scrollbar.

Like, the lowest line of text becomes uppermost (or near uppermost) ☑ momentarily, then a bounce back of around half a page, leaving the line near mid-screen.

This was not a frequent occurrence. It might occur only when speed-reading. I did not attempt to make it reproducible, but if I recall correctly: when the ~half-page bounce occurs, the next Page Down will 'revert' the bounce (i.e. ~half a page down) then subsequent strokes of Page Down will behave normally (0.9).

@grahamperrin

This comment has been minimized.

@turt2live turt2live merged commit baef982 into matrix-org:develop Apr 28, 2021
@aaronraimist aaronraimist deleted the page-up-down branch April 29, 2021 01:20
@grahamperrin

This comment has been minimized.

@t3chguy
Copy link
Member

t3chguy commented May 5, 2021

See topic of #element-web:matrix.org

image

@grahamperrin
Copy link

/me thanks @t3chguy and switches from the deploy-preview server to https://develop.element.io/

@grahamperrin

This comment has been minimized.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paging down or up does not page far enough
4 participants