Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use fallback avatar only for DMs with 2 people #6144

Closed

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Jun 5, 2021

Fixes element-hq/element-web#17559
Fixes element-hq/element-web#9929
Fixes element-hq/element-web#18747

This should cause the following behaviour if a room has no avatar: If a room is a DM and has two members, the other member's (the member that is not you) avatar will be used as the room avatar. In any other case, the first latter of the room name will be used.

Using an avatar of a user in a non-DM/a room with multiple people seems confusing


Here's what your changelog entry will look like:

✨ Features

Preview: https://6157120e7e455f00d5f336ee--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@t3chguy t3chguy requested a review from a team June 7, 2021 10:21
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise

@t3chguy t3chguy requested a review from a team June 7, 2021 12:14
@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2021

Needs product input as this ought to be consistent across Element clients

@SimonBrandner SimonBrandner added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 4, 2021
andybalaam added a commit to andybalaam/matrix-react-sdk that referenced this pull request Sep 30, 2021
@andybalaam
Copy link
Contributor

I worked on some tests for this and added them at #6895

@SimonBrandner SimonBrandner deleted the fix/auto-avatars branch October 1, 2021 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
4 participants