This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Don't set font-family explicitly
#6272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
force-pushed
the
fix/explicit-font/14163
branch
from
c0679fc to
22ddd81
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
force-pushed
the
fix/explicit-font/14163
branch
from
22ddd81 to
43732e5
Compare
turt2live
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
I think this is fine, but feels just slightly too risky to land at this point in the cycle. Our RC is scheduled for Tuesday, and I've set a reminder to land this for after that happens.
Largely my concern is that we won't notice in time if one of these were to go wrong 😅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#14163
Some parts of the code say that the
font-familyis necessary for FF, though a quick test didn't show any problems 🤷♂️ I've left out code blocks as those should be always monospace