Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Improve and consolidate typing #6345

Merged
merged 6 commits into from
Jul 14, 2021
Merged

Improve and consolidate typing #6345

merged 6 commits into from
Jul 14, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 10, 2021

@t3chguy t3chguy mentioned this pull request Jul 10, 2021
Merged
@t3chguy t3chguy requested a review from poljar July 10, 2021 15:00
@t3chguy
Copy link
Member Author

t3chguy commented Jul 10, 2021

@poljar could I just get you to give 2634ed9 (#6345) a once over - TS pointed out some issues and they seem legit.

https://buildkite.com/matrix-dot-org/matrix-react-sdk/builds/14052#3e2aee1a-39ac-4ae0-a552-da1351f52e6e has the failure log

@t3chguy t3chguy marked this pull request as ready for review July 10, 2021 15:01
@t3chguy t3chguy requested a review from a team July 10, 2021 15:01
turt2live
turt2live approved these changes Jul 11, 2021
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

src/components/structures/RoomDirectory.tsx Outdated Show resolved Hide resolved
src/components/views/elements/MiniAvatarUploader.tsx Outdated Show resolved Hide resolved
@t3chguy t3chguy requested a review from turt2live July 12, 2021 08:10
turt2live
turt2live approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm barring conflcits

@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
ae6eaa5 
… t3chguy/ts/c1

� Conflicts:
�	src/components/structures/RoomDirectory.tsx
�	src/components/views/room_settings/RoomPublishSetting.tsx
poljar
poljar approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, hooray for typing.

src/Searching.ts Show resolved Hide resolved
@t3chguy t3chguy merged commit 57f9b81 into develop Jul 14, 2021
@t3chguy t3chguy deleted the t3chguy/ts/c1 branch July 14, 2021 16:19
@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@turt2live turt2live turt2live approved these changes

@poljar poljar poljar approved these changes

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t3chguy @poljar @turt2live @dbkr