This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Set room highlight from unread_notification_count #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -163,6 +157,11 @@ module.exports = React.createClass({ | |||
| this.setState(newState); | |||
| }, | |||
|
|
|||
| onRoomReceipt: function(receiptEvent, room) { | |||
| // because if we read a notification, it will affect notification count | |||
| this.refreshRoomList(); | |||
There was a problem hiding this comment.
We should check if it is the user's receipt and not someone else then in order to prevent refreshing the room list for every receipt.
|
LGTM other than comments. |
|
Comments addressed |
|
LGTM |
|
This has changed slightly so quick ptal? |
| if (rooms[i].hasMembershipState(MatrixClientPeg.get().credentials.userId, 'invite')) { | ||
| ++notifCount; | ||
| } else if (rooms[i].unread_notifications && rooms[i].unread_notifications['notification_count']) { | ||
| notifCount += rooms[i].unread_notifications['notification_count']; |
There was a problem hiding this comment.
I thought we had getters now for this?
|
LGTM aside from comment |
|
ahem apply patch the right branch... |
|
LGTM :) |
dbkr
added a commit
that referenced
this pull request
Jan 21, 2016
Set room highlight from unread_notification_count
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#58 and matrix-org/synapse#456