This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Upgrade highlight.js #6973
Merged
Upgrade highlight.js #6973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major version bump for highlight.js. Update usage of deprecated function & some cleanups.
dbkr
added
the
T-Task
dbkr
added a commit
to element-hq/element-web
that referenced
this pull request
Oct 18, 2021
CSS update for matrix-org/matrix-react-sdk#6973
turt2live
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
lgtm, though CI is unhappy with:
src/components/views/elements/SyntaxHighlight.tsx:18:10 - error TS2614: Module '"highlight.js"' has no exported member 'highlightBlock'. Did you mean to use 'import highlightBlock from "highlight.js"' instead?
--
|
| 18 import { highlightBlock } from 'highlight.js';
turt2live
approved these changes
Oct 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major version bump for highlight.js. Update usage of deprecated function & some cleanups.
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://616dc1587783b2097e463c31--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.