Add setting for enabling location sharing

[andybalaam]

This is slightly complicated by the presence of a labs flag too.

When the labs flag is ON:

• this setting appears
• locations appear in the timeline

When this setting AND the labs flag are BOTH ON:

• the location sharing button appears in composer

If there is a better way of dynamically controlling which settings appear based on labs flags, please let me know.

---

Here's what your changelog entry will look like:

✨ Features

• Add setting for enabling location sharing (#7547). Contributed by @andybalaam.

Preview: https://61e193080fa20c1d3e0f0e0f--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

[t3chguy]

This should've leveraged Settings controllers to be always off when feature_location_share is off, e.g

matrix-react-sdk/src/settings/Settings.tsx

Lines 857 to 865 in 7b95202

	"Spaces.enabledMetaSpaces": {
	supportedLevels: LEVELS_ACCOUNT_SETTINGS,
	default: {
	[MetaSpace.Home]: true,
	},
	controller: new IncompatibleController("feature_spaces_metaspaces", {
	[MetaSpace.Home]: true,
	}, false),
	},

[witchent]

I haven't checked it yet, but it sounds to me like I can enable location sharing, which makes it so I can share the location of others, right?
Wasn't the rational for disabling it in the first place the privacy aspect? If someone else can just enable sharing my location data I don't see why this has to be a setting anyway (why would I ever want to restrict my own actions?)

[t3chguy]

No, the feature lets you share a location of your choice on a map, or your current GPS location (not live).
You can't magically pull locations from other users.

[witchent]

My bad, I thought this was about forwarding (should have read more carefully)