This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix people section DropTarget and refactor Rooms #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set the verb for the people section to "tag as direct chat". This requires some CSS modifications to Riot because it's a long bit of text relative to, say, "demote". - Because it's quite useful to be able to set the DM status of a room with just a boolean, add a convenience function for guessing a DM member and setting the DM flag on that room with the resulting member.
dbkr
suggested changes
Mar 17, 2017
src/Rooms.js
Outdated
|
|
||
| // give some time for the user to see the icon change first, since | ||
| // this will hide the context menu once it completes | ||
| return q.delay(500).then(() => { |
There was a problem hiding this comment.
This should be done in the UI code since it's a UI thing: it doesn't make sense in general for a utility function to delay before resolving.
|
The tests should pass if you merge develop now |
dbkr
approved these changes
Mar 27, 2017
martindale
pushed a commit
to FabricLabs/matrix-react-sdk
that referenced
this pull request
Dec 8, 2018
Add getMediaConfig()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires element-hq/element-web#3458