This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Allow opening external Matrix URIs #7700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Raimist <aaron@raim.ist>
t3chguy
approved these changes
Feb 2, 2022
| @@ -1388,6 +1389,8 @@ export default class MatrixChat extends React.PureComponent<IProps, IState> { | |||
|
|
|||
| StorageManager.tryPersistStorage(); | |||
|
|
|||
| navigator.registerProtocolHandler("matrix", "/#/%s"); | |||
There was a problem hiding this comment.
This may want to happen on an in-app user interaction (Toast?) so the user understands the impact, will need @matrix-org/product input
There was a problem hiding this comment.
We'd like to be consistent with other areas of the app and have a toast first. Redirecting to design for input
t3chguy
added
the
T-Enhancement
Signed-off-by: Aaron Raimist <aaron@raim.ist>
Signed-off-by: Aaron Raimist <aaron@raim.ist>
aaronraimist
added a commit
to aaronraimist/riot-web
that referenced
this pull request
Feb 9, 2022
Maybe this will fix the tests for matrix-org/matrix-react-sdk#7700 Signed-off-by: Aaron Raimist <aaron@raim.ist>
Signed-off-by: Aaron Raimist <aaron@raim.ist>
This reverts commit 2277ec4. Signed-off-by: Aaron Raimist <aaron@raim.ist>
|
I've added Product to the reviewers here - would it be possible to add a clear description here of the change and what user's could expect to see? I imagine that will speed up the review process :) |
|
Thank you for the contribution! To merge this we would need:
I'm going to mark this PR as draft until these can be done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#16875
Here's what your changelog entry will look like:
✨ Features