Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Prefer RoomStateEvent.Update where possible as it fires far less #7878

Merged
merged 12 commits into from
Feb 24, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 22, 2022

Fixes matrix-org/matrix-js-sdk#2191
Requires matrix-org/matrix-js-sdk#2192


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr7878--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 22, 2022
@t3chguy t3chguy requested a review from a team as a code owner February 22, 2022 18:26
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks fine - definitely something to test in practice rather than in review.

CI looks unhappy, though.

@t3chguy t3chguy enabled auto-merge (squash) February 24, 2022 13:17
@t3chguy t3chguy merged commit c257bc3 into develop Feb 24, 2022
@t3chguy t3chguy deleted the t3chguy/fix/2191 branch February 24, 2022 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace RoomState.members
2 participants