-
-
Notifications
You must be signed in to change notification settings - Fork 830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
Codecov Report
@@ Coverage Diff @@
## develop #7992 +/- ##
===========================================
- Coverage 30.85% 26.79% -4.07%
===========================================
Files 893 866 -27
Lines 50793 51950 +1157
Branches 12928 13163 +235
===========================================
- Hits 15671 13918 -1753
- Misses 35122 38032 +2910
|
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
This PR contends with #8558 |
Apologies for slow followup. After discussing with Michael, we decided that we would like to proceed with this PR and will request for the competing PR to be split up and cover the time format in the filename. |
Thanks for the PR! Sorry it took so long to get considered. We've decided to merge the changes from this and #9142 into a single PR to ease the requirements raised by the Product team, and are closing this PR as a result. Hopefully this should mean the code goes live soon. You can see the new PR here: #9440 |
Fixes element-hq/element-web#19724
Signed-off-by: Ritik Kumar sinharitik18112835@gmail.com
Here's what your changelog entry will look like:
✨ Features
Preview: https://pr7992--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.