This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
First iteration on improving login UI #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 19, 2017 10:08
This makes the following changes: - Improve CountryDropdown by allowing all countries to be displayed at once and using PNGs for performance (trading of quality - the pngs are scaled down from 32px to 25px) - "I want to sign in with" dropdown to select login method - MXID login field that suffixes HS domain (whether custom or matrix.org) and prefixes "@" - Email field which is secretly the same as the username field but with a different placeholder - No more login flickering when changing ServerConfig (!) fixes element-hq/element-web#1517 This implements most of the design in element-hq/element-web#3524 but neglects the phone number login:  This will be updated in another PR to implement desired things: - Country code visible once a country has been selected (propbably but as a prefix to the phone number input box. - Use square flags - Move CountryDropdown above phone input and make it show the full country name when not expanded - Auto-select country based on IP
Custom servers may not be configured such that their domain name === domain part.
dbkr
approved these changes
Apr 21, 2017
lukebarnard1
pushed a commit
to element-hq/element-web
that referenced
this pull request
Apr 21, 2017
lukebarnard1
added a commit
to element-hq/element-web
that referenced
this pull request
Apr 21, 2017
Cosmetics to go with matrix-org/matrix-react-sdk#811
dbkr
added a commit
that referenced
this pull request
Aug 29, 2017
Broken by the change from onHsUrlChanged to onServerConfigChanged in #811 where ForgotPassword got missed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements most of the design in element-hq/element-web#3524:
TODO in this PR:
:server.nameTODO in other PRs:
:server.namein the username box.Screenshots:
This neglects the phone number login:
