Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fixes issue #21381 #8199

Closed
wants to merge 4 commits into from
Closed

Fixes issue #21381 #8199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f875aac
Fixes issue #21381
goelesha Mar 30, 2022
2c01aaf
Merge branch 'matrix-org:develop' into issue#21381
goelesha Mar 31, 2022
46bbc6b
Merge branch 'issue#21381' of https://github.com/goelesha/matrix-reac…
goelesha Mar 31, 2022
34037c6
Merge branch 'develop' into issue#21381
goelesha Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/views/messages/MessageTimestamp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export default class MessageTimestamp extends React.Component<IProps> {
className="mx_MessageTimestamp"
title={formatFullDate(date, this.props.showTwelveHour)}
aria-hidden={true}
min-height="1rem"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no min-height attributes on a span HTML element.

My hunch is that we would have to update the mx_EventTile_line CSS class rather than the message timestamp. It's positioned absolutely and therefore will not affect the height of the event tile

>
{ timestamp }
</span>
Expand Down
1 change: 1 addition & 0 deletions src/components/views/rooms/EventTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,6 +1307,7 @@ export class UnwrappedEventTile extends React.Component<IProps, IState> {
href={permalink}
onClick={this.onPermalinkClicked}
aria-label={formatTime(new Date(this.props.mxEvent.getTs()), this.props.isTwelveHour)}
min-height="1rem"
>
{ timestamp }
</a>;
Expand Down