-
-
Notifications
You must be signed in to change notification settings - Fork 832
Improve tooltip positioning #8219
Improve tooltip positioning #8219
Conversation
5aa74cf
to
6d44bc6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #8219 +/- ##
===========================================
- Coverage 30.85% 28.67% -2.18%
===========================================
Files 893 851 -42
Lines 50793 49774 -1019
Branches 12928 12655 -273
===========================================
- Hits 15671 14274 -1397
- Misses 35122 35500 +378
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this requires design review before code review is a reasonable course of action, to verify the tooltip behaviour and expectations for at least the sample cases in the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@weeman1337 can you fix the merge conflicts so that it can be reviewed, thanks! |
6d44bc6
to
09bf4ad
Compare
09bf4ad
to
f5d84a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No questions otherwise, this is a great improvement!
f5d84a5
to
e3d65fe
Compare
Signed-off-by: Michael Weimann <michaelw@matrix.org>
e3d65fe
to
7837b66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, but for future reference, please avoid force pushing after review since it makes it more difficult to determine what's changed
I actually wanted to fix the tooltip of the „decryption issue“ message.
After spending some time on this I found that tooltips can be improved in other places as well.
This PR partially refactors tooltips. Worth mentioning:
yOffset
❗Notes
This is just a suggestion. But so far in my opinion this improves the tooltips.
The changes are improving the tooltip positioning in many places, for example:
(tooltip appears above another button)
(unaligned)
(cut off)
(tooltip appears above another button)
Notes: Tooltip positioning has been improved
Here's what your changelog entry will look like:
🐛 Bug Fixes
Preview: https://pr8219--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.