This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make dialog's header compatible with RTL layout #8231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
bot
added
the
T-Task
Codecov Report
@@ Coverage Diff @@
## develop #8231 +/- ##
========================================
Coverage 29.25% 29.25%
========================================
Files 863 863
Lines 49876 49876
Branches 12696 12696
========================================
Hits 14592 14592
Misses 35284 35284
|
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
.mx_Dialog_cancelButton is used on BaseDialog.tsx and HostSignupDialog.tsx. Both cases the button is placed inside .mx_Dialog_header. See: _LocationViewDialog.scss, where .mx_Dialog_cancelButton is nested under .mx_Dialog_header. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
|
The close button should be dependent on the dialog itself rather than the title as theoretically there would be a case where something such as an image could be placed above the title, so placing the button with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Cherry-picked from #8217
This PR makes the dialog's header compatible with a RTL (Right-To-Left) layout, by including the close button into the flexbox which automatically takes care of the direction of child elements. The button will be placed 3px (magic number) above the first baseline.
Current implementation
Image 1 (Left-To-Right layout with one line title)
Image 2 (Left-To-Right layout with two lines title)
Image 3 (Right-to-Left layout with one line title)
The button should be placed on the left side.
With this PR:
Image 4 (Left-To-Right layout with one line title)
Image 5 (Left-To-Right layout with two lines title)
Image 6 (Right-to-Left layout with one line title)
Image 7 (Right-to-Left layout with two lines title)
Image 8 (InvitationDialog's header in Hebrew)
Image 9 (the header with
mx_Dialog_headerWithButtonemulated)The title text is placed at the center as expected.
type: task
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr8231--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.